Benchmark rally add flags #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jsoriano
reviewed
Nov 30, 2023
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Co-authored-by: Jaime Soriano Pastor <[email protected]>
ruflin
reviewed
Nov 30, 2023
ruflin
reviewed
Nov 30, 2023
docs/howto/rally_benchmarking.md
Outdated
|
|
||
| ## Loading a package from registry | ||
| If the `package-from-registry` flag is used, the package installed in Kibana and its assets referenced in the track will be loaded from registry. The format of the flag value is `%packageName%-%packageVersion%`. | ||
| You still need to run the command from the root of the local package in order to read the benchmark scenario (`benchmark` flag). |
There was a problem hiding this comment.
Does this mean I need to run two commands? I tried the following:
elastic-package benchmark rally --benchmark pod-benchmark -v --package-from-registry=kubernetes-1.55.0
Can you share a working example that users can just copy/paste?
There was a problem hiding this comment.
your example is correct: I've reworded the docs, please let me know if it's clearer now
jsoriano
reviewed
Nov 30, 2023
💚 Build Succeeded
History
cc @aspacca |
jsoriano
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
package-from-registryanduse-corpus-at-pathflags.See updated docs for usage.