Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump corpus generator v0.6.0 #1491

Closed
wants to merge 23 commits into from

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Oct 6, 2023

resolves manually conflicts at #1478
fixes #1474

@marc-gr do we use elsewhere the .size/.tot_events package specs?
I could not find any in integrations, but in case there are there, we should adapt a different strategy

@aspacca aspacca requested review from mrodm and marc-gr October 6, 2023 04:27
@aspacca aspacca self-assigned this Oct 6, 2023
@aspacca
Copy link
Contributor Author

aspacca commented Oct 6, 2023

@mrodm we still had size required in the package-spec: I've changed it in elastic/package-spec#639

it would be better to include in v3.0.0 of the spec

since the only use of size is currently only in the elastic-package and package-spec itself if think it's safe to not have a code handling the migration, what do you think?

@aspacca aspacca mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update system benchmark to use totEvents and drop deprecated size field from package-spec
2 participants