Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose config - bind mount /run/service_logs/ in Agent container #1236

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 24, 2023

This mounts the service_logs directory at /run/service_logs for the purpose of testing the Filebeat journald input. It is a workaround for an upstream ubuntu 20.04->systemd bug (see linked issue).

Closes #1235
Unblocks elastic/integrations#5984

This mounts the service_logs directory at /run/service_logs for the purpose
of testing the journald input. It is a workaround but an upstream bug.

Closes elastic#1235
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add a comment linking to the issue before merging.

@@ -137,6 +137,7 @@ services:
- type: bind
source: ../../../tmp/service_logs/
target: /tmp/service_logs/
# Mount service_logs under /run too as a testing workaround for the journald input (see elastic-package#1235).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@andrewkroh andrewkroh merged commit ee74094 into elastic:main Apr 25, 2023
andrewkroh added a commit to andrewkroh/integrations that referenced this pull request Apr 26, 2023
system tests for the journald input have been disabled to a segfault. This uses a workaround
to avoid that segfault so we can continue testing.

Closes elastic#2602
Relates elastic/elastic-package#1236
andrewkroh added a commit to elastic/integrations that referenced this pull request Apr 27, 2023
system tests for the journald input have been disabled to a segfault. This uses a workaround
to avoid that segfault so we can continue testing.

While performing that testing I discovered that neither iptables nor journald were
aligned with the current ECS definition of the log.syslog.* fields. ECS added
numerous log.syslog fields that should be used by journald/iptables
instead of syslog.*.

And because journald is an input package this needs to be done without
an Ingest Pipeline so that users with custom pipelines can benefit.

Bump stack version for the iptables integration to get journald input fixes.

Closes #2602
Relates elastic/elastic-package#1236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add service_logs bind mount at /run/service_logs
3 participants