-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose config - bind mount /run/service_logs/ in Agent container #1236
Merged
andrewkroh
merged 2 commits into
elastic:main
from
andrewkroh:bugfix/service-logs-mount-run
Apr 25, 2023
Merged
docker-compose config - bind mount /run/service_logs/ in Agent container #1236
andrewkroh
merged 2 commits into
elastic:main
from
andrewkroh:bugfix/service-logs-mount-run
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mounts the service_logs directory at /run/service_logs for the purpose of testing the journald input. It is a workaround but an upstream bug. Closes elastic#1235
4 tasks
jsoriano
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add a comment linking to the issue before merging.
jsoriano
approved these changes
Apr 25, 2023
@@ -137,6 +137,7 @@ services: | |||
- type: bind | |||
source: ../../../tmp/service_logs/ | |||
target: /tmp/service_logs/ | |||
# Mount service_logs under /run too as a testing workaround for the journald input (see elastic-package#1235). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
💚 Build Succeeded
History
|
andrewkroh
added a commit
to andrewkroh/integrations
that referenced
this pull request
Apr 26, 2023
system tests for the journald input have been disabled to a segfault. This uses a workaround to avoid that segfault so we can continue testing. Closes elastic#2602 Relates elastic/elastic-package#1236
andrewkroh
added a commit
to elastic/integrations
that referenced
this pull request
Apr 27, 2023
system tests for the journald input have been disabled to a segfault. This uses a workaround to avoid that segfault so we can continue testing. While performing that testing I discovered that neither iptables nor journald were aligned with the current ECS definition of the log.syslog.* fields. ECS added numerous log.syslog fields that should be used by journald/iptables instead of syslog.*. And because journald is an input package this needs to be done without an Ingest Pipeline so that users with custom pipelines can benefit. Bump stack version for the iptables integration to get journald input fixes. Closes #2602 Relates elastic/elastic-package#1236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mounts the service_logs directory at
/run/service_logs
for the purpose of testing the Filebeatjournald
input. It is a workaround for an upstream ubuntu 20.04->systemd bug (see linked issue).Closes #1235
Unblocks elastic/integrations#5984