-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: line path with ordered xValues #824
Conversation
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes: - fit functions are now available also on stacked charts - the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis - Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case - for zero-based charts (bar and area charts) the fit option doesn't have any effects - djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`. fix #766 fix #715 close #450
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 74.07% 74.09% +0.02%
==========================================
Files 277 277
Lines 9436 9440 +4
Branches 2037 2037
==========================================
+ Hits 6990 6995 +5
+ Misses 2437 2436 -1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works great
I've added a small comment to improve the testing
Co-authored-by: Marco Vettorello <[email protected]>
## [21.3.1](v21.3.0...v21.3.1) (2020-09-17) ### Bug Fixes * line path with ordered xValues ([#824](#824)) ([5a73a3a](5a73a3a))
🎉 This PR is included in version 21.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [21.3.1](elastic/elastic-charts@v21.3.0...v21.3.1) (2020-09-17) ### Bug Fixes * line path with ordered xValues ([opensearch-project#824](elastic/elastic-charts#824)) ([8568adc](elastic/elastic-charts@8568adc))
Summary
fixes #823
re-fixes #680
Fix line path with ordered
xValues
onOrdinal
scales.Before
After
Checklist
src/index.ts
(and stories only import from../src
except for test data & storybook)