fix: set uninitialized state when removeSpec action is called #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reset the chart state to not initialized when removing a spec. After elastic#723 PR that reduced the number of steps on the state machine when parsing, the removeSpec action wasn't accounted on that refactoring causing side effects when removing/switching a spec on the chart configuration due to the state being in an wrong status. fix elastic#738
markov00
added
bug
markov00
pushed a commit
that referenced
this pull request
Jul 6, 2020
# [19.8.0](v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([#739](#739)) ([35b8caf](35b8caf)), closes [#723](#723) [#738](#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([#737](#737)) ([ab5e413](ab5e413)), closes [#701](#701) * add custom annotation tooltip ([#727](#727)) ([435c67c](435c67c))
|
🎉 This PR is included in version 19.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nickofthyme
reviewed
Jul 8, 2020
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.8.0](elastic/elastic-charts@v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([opensearch-project#739](elastic/elastic-charts#739)) ([9c49c90](elastic/elastic-charts@9c49c90)), closes [opensearch-project#723](elastic/elastic-charts#723) [opensearch-project#738](elastic/elastic-charts#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([opensearch-project#737](elastic/elastic-charts#737)) ([2fa5a0b](elastic/elastic-charts@2fa5a0b)), closes [opensearch-project#701](elastic/elastic-charts#701) * add custom annotation tooltip ([opensearch-project#727](elastic/elastic-charts#727)) ([f03d566](elastic/elastic-charts@f03d566))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit reset the chart state to not initialized when removing a spec. After #723 PR that
reduced the number of steps on the state machine when parsing, the removeSpec action wasn't
accounted on that refactoring causing side effects when removing/switching a spec on the chart
configuration due to the state being in an wrong status.
fix #738
Checklist