-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build/type issue with DataGenerator #671
Conversation
- Move around types to exclude mocks directory - Remove import of seedrandom from dist files - Add default rng function for DataGenerator
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 72.97% 72.91% -0.06%
==========================================
Files 266 266
Lines 8634 8641 +7
Branches 1698 1700 +2
==========================================
Hits 6301 6301
- Misses 2294 2301 +7
Partials 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 19.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [19.3.0](elastic/elastic-charts@v19.2.0...v19.3.0) (2020-05-08) ### Bug Fixes * build/type issue with DataGenerator ([opensearch-project#671](elastic/elastic-charts#671)) ([01844ac](elastic/elastic-charts@01844ac)) ### Features * **partition:** linked text maximum length config ([opensearch-project#665](elastic/elastic-charts#665)) ([e37cb8f](elastic/elastic-charts@e37cb8f))
Summary
Bug caused by
DataGenerator
Class now expecting a random number generator. Broke EUI docs.Checklist
src/index.ts
(and stories only import from../src
except for test data & storybook)