-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve VRT developer experience #653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
enhancement
New feature or request
visual testing
issues related to visual testing
labels
Apr 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 72.74% 72.91% +0.17%
==========================================
Files 264 266 +2
Lines 8487 8585 +98
Branches 1655 1682 +27
==========================================
+ Hits 6174 6260 +86
- Misses 2275 2287 +12
Partials 38 38
Continue to review full report at Codecov.
|
nickofthyme
reviewed
Apr 28, 2020
nickofthyme
approved these changes
Apr 29, 2020
Co-Authored-By: Nick Partridge <[email protected]>
🎉 This PR is included in version 19.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
released
Issue released publicly
visual testing
issues related to visual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames
yarn jest:integration
script toyarn test:integration
to align the name to the rest of the test scripts we have.This PR adds one more script to run the VRT directly against a local storybook server:
This will reduce the VRTs time removing the build time spent on the storybook build.
I've updated the docs to include the use of
--testNamePattern
to limit the test on a specific regex instead of the previously implemented env variable in this PR.