Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve VRT developer experience #653

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Apr 28, 2020

Summary

This PR renames yarn jest:integration script to yarn test:integration to align the name to the rest of the test scripts we have.

This PR adds one more script to run the VRT directly against a local storybook server:

yarn test:integration:local

This will reduce the VRTs time removing the build time spent on the storybook build.

I've updated the docs to include the use of --testNamePattern to limit the test on a specific regex instead of the previously implemented env variable in this PR.

@markov00 markov00 added enhancement New feature or request visual testing issues related to visual testing labels Apr 28, 2020
@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #653 into master will increase coverage by 0.17%.
The diff coverage is 81.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   72.74%   72.91%   +0.17%     
==========================================
  Files         264      266       +2     
  Lines        8487     8585      +98     
  Branches     1655     1682      +27     
==========================================
+ Hits         6174     6260      +86     
- Misses       2275     2287      +12     
  Partials       38       38              
Impacted Files Coverage Δ
src/chart_types/xy_chart/legend/legend.ts 84.61% <ø> (ø)
...ypes/xy_chart/renderer/canvas/annotations/index.ts 30.00% <ø> (ø)
...ypes/xy_chart/renderer/canvas/annotations/lines.ts 25.00% <ø> (ø)
...types/xy_chart/renderer/canvas/annotations/rect.ts 23.52% <ø> (ø)
..._types/xy_chart/renderer/canvas/primitives/rect.ts 5.35% <ø> (ø)
.../chart_types/xy_chart/renderer/canvas/xy_chart.tsx 86.30% <ø> (ø)
src/chart_types/xy_chart/utils/specs.ts 100.00% <ø> (ø)
src/scales/index.ts 100.00% <ø> (ø)
src/components/tooltip/tooltip.tsx 26.66% <26.66%> (ø)
...ypes/xy_chart/renderer/dom/annotation_tooltips.tsx 52.13% <30.76%> (-3.11%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8a9d8...4f3005b. Read the comment docs.

integration/helpers.ts Outdated Show resolved Hide resolved
.ci/run.sh Show resolved Hide resolved
integration/defaults.js Show resolved Hide resolved
wiki/testing.md Outdated Show resolved Hide resolved
Co-Authored-By: Nick Partridge <[email protected]>
@markov00 markov00 merged commit aa6ff42 into elastic:master Apr 29, 2020
@markov00 markov00 deleted the 2020_04_28-improve_vrt_dx branch April 29, 2020 13:34
@markov00
Copy link
Member Author

🎉 This PR is included in version 19.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released Issue released publicly visual testing issues related to visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants