-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): improve positioning with popperjs #651
Merged
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
5ee6ad0
fix: tooltip container scroll issue
nickofthyme 8a18b7a
Merge branch 'master' into fix/tooltip-scroll
nickofthyme 072b09f
fix: type error in dist
nickofthyme 0140bd2
fix: possibly fix the scrollbar in all charts
markov00 f574e6d
refactor: improve tooltip postioning logic
nickofthyme 5e09582
cleanup: remove highlight type, update popper
nickofthyme 83ef7e4
Merge branch 'master' into feat/popper-poc
nickofthyme f91b9cf
refactor: tooltip portal to functional component
nickofthyme b379f99
refactor: decouple tooltip and portal logic
nickofthyme 547dab4
refactor: move portal into seperate folder and cleanup types
nickofthyme e0fecf1
feat: expand tooltip placement options
nickofthyme 24892d1
refactor: combine real anchor and invisble anchor ref into single prop
nickofthyme 618148e
refactor: move annotations, pull out rect and line tooltip render com…
nickofthyme e07649a
refactor: line and rect annotations to use Portal
nickofthyme 3b30486
fix: line tooltip annotation position
nickofthyme 87a57b4
fix: final cleanup of code before ready for review
nickofthyme 4184fcb
fix: use full version of popper until library is using babel for tree…
nickofthyme df7675f
fix: cleanup debug styles in portal
nickofthyme c3b31dc
Merge branch 'master' into feat/popper-poc
nickofthyme 73f8495
feat: add fallback knobs
nickofthyme a0b7cd4
fix: settings error
nickofthyme e64700a
fix: tooltip render on partition charts
nickofthyme 842b11b
fix: variable naming
nickofthyme afc7227
test: update annotations utils to use non-projected cursor
nickofthyme 5227c93
ci: enforce no .only in tests on ci
nickofthyme 9d2deb5
test: update vrt
nickofthyme a43f7d8
test: update vrt screenshots based on changes
nickofthyme 6261e6c
fix: multiple charts issue and scrolling issues
nickofthyme ccfe32e
fix: prevent popper updates when tooltip is not visible
nickofthyme dc5a01e
Merge branch 'master' into feat/popper-poc
nickofthyme 8094278
fix: scss and typings build issues
nickofthyme 7467d2a
test: update vrt to better test tooltip placement and rotations
nickofthyme 884aacb
Merge branch 'master' into feat/popper-poc
nickofthyme d76de27
Merge branch 'master' into feat/popper-poc
nickofthyme eeb574f
test: fix missed vrt update
nickofthyme a6f5ded
Merge branch 'master' into feat/popper-poc
monfera 26954a8
test: revert changes to vrt, add to seperate pr
nickofthyme a38ada2
refactor: rename portal to tooltip portal
nickofthyme e7256b6
refactor: cleanup hook logic
nickofthyme 95def5f
Merge branch 'master' into feat/popper-poc
nickofthyme ddc44cb
fix: remove forced non-null
nickofthyme 9d43a4b
fix: remove cruft from highlight tooltip type
nickofthyme c517407
test: remove all stale screenshots
nickofthyme 37bd0b8
test: add back missing screenshots
nickofthyme 0b365c6
docs: update api docs
nickofthyme 7060feb
test: update screenshots
nickofthyme 7efd73f
fix: variable naming in playground
nickofthyme 1c3b868
Merge branch 'master' into feat/popper-poc
monfera 9c534e7
fix: broken knobs, add rotation based defaults for popper placement
nickofthyme 2484f23
docs: fix api-extractor warnings for tooltips
markov00 492b426
docs: fix api-extractor warnings for placements
markov00 514d8ac
Merge branch 'master' into feat/popper-poc
nickofthyme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markov00 Is this required? I thought
@public
was the default.