-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: decouple legend and tooltip phase 1 #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I only have some naming suggestions
dca75da
to
e31cf93
Compare
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 71.78% 71.49% -0.29%
==========================================
Files 208 208
Lines 6216 6119 -97
Branches 1199 1169 -30
==========================================
- Hits 4462 4375 -87
+ Misses 1738 1727 -11
- Partials 16 17 +1
Continue to review full report at Codecov.
|
Move `Datum`, `Rotation`, `Position` and `Color` to `utils/commons`. Decouple legend from axis position method and move the `scales` to `utils/scales`.
Move `Datum`, `Rotation`, `Position` and `Color` to `utils/commons`. Decouple legend from axis position method and move the `scales` to `utils/scales`.
Summary
This is the first phase to clean and decouple the current code for legend and tooltip from the XYChart dependency.
In this PR I've just moved out 3 types
Rotation
,Datum
andPosition
from the XYChart to the mainsrc/utils/commons.ts
and I've also moved 1 level up thescales
folderChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials