fix(Metric): Cards should only show one focus halo on ::focus event
#2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
changed the title
::focus event::focus event
alexwizp
changed the title
::focus event::focus event
markov00
reviewed
May 24, 2024
markov00
approved these changes
May 27, 2024
markov00
changed the title
::focus event::focus event
nickofthyme
pushed a commit
that referenced
this pull request
May 28, 2024
# [65.1.0](v65.0.0...v65.1.0) (2024-05-28) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^94.5.0 ([#2433](#2433)) ([b13ded9](b13ded9)) * **deps:** update dependency @playwright/test to ^1.44.0 ([#2434](#2434)) ([faf36aa](faf36aa)) * **Metric:** should only show one focus halo on `::focus` event ([#2441](#2441)) ([96b0779](96b0779)) * react component type errors ([#2440](#2440)) ([f0b3a00](f0b3a00)) ### Features * **legend:** add legend stats (table view) ([#2426](#2426)) ([c22f767](c22f767))
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-dev/issues/3430
Closes: https://github.com/elastic/observability-dev/issues/3391
When we use the
Metric ChartinKibana, we have a problem where the focus halo is shown twice. I think we can explicitly add the propertyoutline: none; to theechMetricText__title buttonto resolve this issue