feat(metric): add text value #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the metric types are updated to align better with the new feature
markov00
changed the title
BREAKING CHANGE: `progressBarDirection` and `trendShape` are now required
nickofthyme
approved these changes
Sep 13, 2022
gvnmagni
approved these changes
Sep 14, 2022
This can give the ability to copy entirely the selected text and not just the truncated one.
nickofthyme
approved these changes
Sep 14, 2022
nickofthyme
approved these changes
Sep 14, 2022
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Sep 17, 2022
# [49.0.0](v48.0.1...v49.0.0) (2022-09-17) ### Bug Fixes * **deps:** update dependency @elastic/eui to v67 ([#1815](#1815)) ([a45b3d3](a45b3d3)) * **metric:** improve multi-line wrapping ([#1816](#1816)) ([f9c790e](f9c790e)) ### Features * **metric:** add a textual value ([#1817](#1817)) ([d7610ad](d7610ad)) * **metric:** add empty cell marker ([#1819](#1819)) ([58ca9c3](58ca9c3)) * **metric:** expose min metric height ([#1825](#1825)) ([c9bd634](c9bd634)) ### BREAKING CHANGES * **metric:** the metric types have been changed: the `value: number` and `valueFormatter` are only available for a numerical, progress bar, or trend metric. For the textual metric, the `value` has a `string` type. The `progressBarDirection` and `trendShape` properties are now required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the ability to render text in place of numerical values.
BREAKING CHANGE
The metric types are updated to align with the new feature. I've introduced a lower type branch, that splits numerical (together with trend/progress) from a textual only metric.
Issues
fix #1801
Checklist
:xy,:partition)closes #123,fixes #123)packages/charts/src/index.tsdark,light,eui-dark&eui-light