-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: timeslip prototype added #1767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
added
:interactions
Interactions related issue
:axis
Axis related issue
:accessibility
Accessibility related issue
:xy
Bar/Line/Area chart related
labels
Jul 31, 2022
buildkite update vrt |
markov00
reviewed
Aug 2, 2022
monfera
force-pushed
the
timeslip-pre-alpha
branch
from
August 2, 2022 11:21
d5181cf
to
b08ba2d
Compare
markov00
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:accessibility
Accessibility related issue
:axis
Axis related issue
:interactions
Interactions related issue
:xy
Bar/Line/Area chart related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the timeslip prototype as a pre-alpha chart type. It's still mostly JS and prototypey, with partly functional dat.gui controls, lacking a tooltip and event callback integration. However it already uses the time raster and chrono utility from Cartesians (those have already been integrated by
xy_chart
from the original timeslip prototype).The intent is to eventually unify what it provides with the production Cartesian charts.
An also discussed, shorter term parallel track is to refactor, typescriptify and round out the implementation and design so it serves as a specifically designed time series chart with cohesive design elements, which shares some attributes with bar charts incl. histograms, line charts and area charts.
Details
There's a recognized tension between generative chart making, such as devising a form of grammar of graphics (significantly generative approaches include Vega / Vega-Lite, Charticulator, Sanddance, some aspects of Tableau) and fixed chart types (Excel, most aspects of Plotly and
elastic-charts
, some aspects of Tableau). This prototype is more of a recognition that it's a challenging design and implementation task to even approach a small point in the design space, and is a source of further work (eg. in the generative direction), rather than vouching for the supremacy of a rigid, chart type based approach.However it is often the case, eg. in data discovery mode, that zoom and pan, interactive re-binning etc. are already valuable, while there's no current compositioning need. It is also often good practice to just visualize a single time series in a chart, and to not imply a possibly untrue degree of continuity of the time series values (which regular line and area charts do).
List of features, some of which are slated for Cartesian integration:
elastic-charts
CartesiansIssues
Checklist
:xy
,:partition
):interactions
,:axis
):theme
label has been added and the@elastic/eui-design
team has been pinged when there areTheme
API changescloses #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light