Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pick up perf and refactor commits as patch release #1713

Merged
merged 2 commits into from
Jun 15, 2022
Merged

chore: pick up perf and refactor commits as patch release #1713

merged 2 commits into from
Jun 15, 2022

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jun 15, 2022 •
edited
Loading

Summary

This PR updates the semantic-release commit analyzer to pick up bot the perf and the refactor commit prefix as patch releases.

@nickofthyme we should also change the current semantic-pull-request app, because is no longer maintained and seems not working anymore (see this PR title for example), to this https://github.com/Ezard/semantic-prs#readme that has the same API, wdyt?

@markov00 markov00 marked this pull request as ready for review June 15, 2022 12:52
@markov00 markov00 added chore :build Build tools / dependencies labels Jun 15, 2022
nickofthyme
nickofthyme approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think these changes are fine. Did you want to bump semantic-release per #1707 in this PR too?

we should also change the current semantic-pull-request app, because is no longer maintained and seems not working anymore (see this PR title for example), to this https://github.com/Ezard/semantic-prs#readme that has the same API, wdyt?

Yeah I think that is fine with me. Do you think this bot would fix the issues mentioned in #1471?

@markov00
Copy link
Member Author

Yeah I think these changes are fine. Did you want to bump semantic-release per #1707 in this PR too?

yep why not!

Yeah I think that is fine with me. Do you think this bot would fix the issues mentioned in #1471?

No, the bug was not caused by the semantic-pull-request github app, but by the github plugin of semantic-release

@markov00 markov00 changed the title pick up perf and refactor commits as patch release chore: pick up perf and refactor commits as patch release Jun 15, 2022
@markov00 markov00 changed the title chore: pick up perf and refactor commits as patch release bad_title: pick up perf and refactor commits as patch release Jun 15, 2022
@markov00 markov00 changed the title bad_title: pick up perf and refactor commits as patch release perf: pick up perf and refactor commits as patch release Jun 15, 2022
@markov00 markov00 changed the title perf: pick up perf and refactor commits as patch release performance: pick up perf and refactor commits as patch release Jun 15, 2022
@markov00 markov00 changed the title performance: pick up perf and refactor commits as patch release chore: pick up perf and refactor commits as patch release Jun 15, 2022
@markov00
Copy link
Member Author

markov00 commented Jun 15, 2022 •
edited
Loading

@nickofthyme semantic-release deps bumped to the last one, I don't see any breaking change that can affect us
and I also added the semantic-release pr bot and tested with some bad titles

@markov00 markov00 merged commit 00fcd3e into elastic:master Jun 15, 2022
@markov00 markov00 deleted the 2022_06_15-update_commit_analyzer branch June 15, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@monfera monfera monfera approved these changes

Assignees
No one assigned
Labels
:build Build tools / dependencies chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markov00 @monfera @nickofthyme