-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(axes): option to fit domain to list of annotation SpecIds
#1641
Conversation
@markov00 I added the rect annotation finite values to the domain. The one question I have is when the domain I wonder if we should filter the |
I don't see this as a problem. If I'm adding an annotation with a data domain that is bigger then the current chart data domain, and I configured my chart to include the annotation domain into the data once, I don't see this as an issue: a rectangle area that covers entirely the chart works fine for me, it doesn't need anything special |
Co-authored-by: Marco Vettorello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, everything works like perfectly, I have also tested with the yNice
prop enabled and it follows that correctly.
Please update the PR description with the changes you have done on the naming
SpecIds
# [46.0.0](v45.1.1...v46.0.0) (2022-04-14) ### Bug Fixes * **axis:** ticks generation for linear scale on bar charts ([#1645](#1645)) ([65d0e7d](65d0e7d)) * **axis:** use correct desired tick count based on axis type ([#1646](#1646)) ([512a6cd](512a6cd)) * **deps:** update dependency @elastic/eui to v53 ([#1639](#1639)) ([34bf325](34bf325)) * **deps:** update dependency @elastic/eui to v54 ([#1642](#1642)) ([6eaca0a](6eaca0a)) ### Features * **axes:** option to fit domain to list of annotation `SpecIds` ([#1641](#1641)) ([220350d](220350d)) * **goal:** auto generated linear ticks ([#1637](#1637)) ([5437d8e](5437d8e)) * **legend:** expose sorting function ([#1644](#1644)) ([128114c](128114c)) ### BREAKING CHANGES * **goal:** goal chart now requires domain min and max to be defined
Summary
Adds the
AxisSpec.domain.includeDataFromIds
option toYDomainBase
. This optional allows specifying a series ofSpecIds
to include into the domain calculation, respective of theirgroupId
. Currently, onlyLineAnnotation
andRectAnnotation
specs are supported, everything else is already included in the domain automatically. Settingdomain.max
ordomain.min
will override this functionality.See pr demo story here
Issues
fix #1411
Checklist
:xy
,:partition
):interactions
,:axis
)closes #123
,fixes #123
)packages/charts/src/index.ts