Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(playground): fix webpack config #1391

Merged
merged 1 commit into from
Sep 20, 2021
Merged

docs(playground): fix webpack config #1391

merged 1 commit into from
Sep 20, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Sep 20, 2021 •
edited
Loading

Details

Fix playground build after breaking it in #1231 or #1178

script now functions as intended...

yarn playground

@nickofthyme nickofthyme added :docs Anything related to documentation, API, storybook skip-newsletter labels Sep 20, 2021
@nickofthyme nickofthyme requested a review from rshen91 September 20, 2021 20:59
@nickofthyme nickofthyme enabled auto-merge (squash) September 20, 2021 21:00
rshen91
rshen91 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yarn playground is back, baby! I also tested locally bringing in a different story example into playground -- no issues 👍🏻

@nickofthyme nickofthyme merged commit 9297ac0 into elastic:master Sep 20, 2021
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 37.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Oct 5, 2021
@nickofthyme nickofthyme deleted the fix-playground branch May 10, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshen91 rshen91 rshen91 approved these changes

Assignees
No one assigned
Labels
:docs Anything related to documentation, API, storybook released Issue released publicly skip-newsletter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickofthyme @rshen91