refactor: scale improvements #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
added
:axis
monfera
force-pushed
the
time-axis-06
branch
3 times, most recently
from
d3d94a0 to
2d2142a
Compare
monfera
force-pushed
the
time-axis-06
branch
from
2d2142a to
6a5a69e
Compare
|
test this |
1 similar comment
|
test this |
|
test this |
|
test this |
monfera
force-pushed
the
time-axis-06
branch
from
0751744 to
ae9b210
Compare
|
test this |
monfera
commented
Sep 17, 2021
Co-authored-by: Nick Partridge <[email protected]>
Co-authored-by: Nick Partridge <[email protected]>
Co-authored-by: Nick Partridge <[email protected]>
Co-authored-by: Nick Partridge <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
monfera
force-pushed
the
time-axis-06
branch
from
85cbf96 to
820f3fd
Compare
|
test this |
nickofthyme
approved these changes
Sep 21, 2021
| export type UnboundedDomainWithInterval = DomainBase; | ||
|
|
||
| /** @public */ | ||
| export type DomainRange = LowerBoundedDomain | UpperBoundedDomain | CompleteBoundedDomain | UnboundedDomainWithInterval; | ||
| /** @public */ | ||
| export type YDomainRange = YDomainBase & DomainRange & LogScaleOptions; | ||
|
|
There was a problem hiding this comment.
I failed to find an simple solution to this in the form of some deep partial keys on the spec factory. I'll keep the PR here for reference. #1399
markov00
approved these changes
Sep 22, 2021
monfera
added a commit
that referenced
this pull request
Sep 22, 2021
* switch to TS 4.4 and bump other deps
* type strength increase via removing many `any` occurrences
* domain oriented generic typing for scales
* replacement and future prevention of coercive `==` and `!=` ops
* refactoring: simplification and shortening of numerous functions, about 300 runtime lines gone
* removal of numerous let, if/then, optional parameters etc.
BREAKING CHANGE: The public type varieties for domains are discontinued, in favor of retaining the single `DomainRange` export, which now has a mandatory `{min: number, max: number}`. The developer can supply `NaN` where a finite min, max or both aren't defined (ie. in place of former effective `undefined`). In addition, some console.warn punctuations changed
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: Nick Partridge <[email protected]>
nickofthyme
added a commit
that referenced
this pull request
Oct 5, 2021
# [37.0.0](v36.0.0...v37.0.0) (2021-10-05) ### Bug Fixes * **debug:** add predictable axis labels sorting order ([#1418](#1418)) ([60fbe7a](60fbe7a)) * **deps:** update dependency @elastic/eui to ^38.1.0 ([#1409](#1409)) ([4ffd018](4ffd018)) * **deps:** update dependency @elastic/eui to ^38.2.0 ([#1416](#1416)) ([34707c3](34707c3)) ### Code Refactoring * cleanup colors ([#1397](#1397)) ([348c061](348c061)) * scale improvements and TS 4.4 ([#1383](#1383)) ([0003bc1](0003bc1)) ### BREAKING CHANGES * `DEFAULT_CHART_MARGINS`, `DEFAULT_GEOMETRY_STYLES`, `DEFAULT_CHART_PADDING` and `DEFAULT_MISSING_COLOR` are no longer exposed as part of the API * The public type varieties for domains are discontinued, in favor of retaining the single `DomainRange` export, which now has a mandatory `{min: number, max: number}`. The developer can supply `NaN` where a finite min, max or both aren't defined (ie. in place of former effective `undefined`). In addition, some console.warn punctuations changed Co-authored-by: Marco Vettorello <[email protected]> Co-authored-by: Nick Partridge <[email protected]>
This was referenced Jan 11, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch to TS 4.4; simplifications; type strength increase via lots of
anyreplacements. Replacement and future prevention of coercive==and!=opsBREAKING CHANGE
The public type variations for domains are discontinued, in favor of retaining the single
DomainRangeexport, which however now has a mandatory{min: number, max: number}. The user can supplyNaNwhere a finite min, max or both aren't defined (ie. in place of former omisison orundefined).Some console.warn punctuations changed.
Details
anys removed from continuous and band scales; oneanyremoved fromScale. Some of theseanyfixes needed some new type assertions in more specific, localized places (very low count), future PRs can attempt to solve those too with type guards or generics.Note to reviewers:
anys, and the downstream type assertions necessitated byanyremoval, because the numerous preexisting (and still extant)anys mean that information can't always be learned from other typesany(eg. inScale) and theasassertions, necessitated by the removal of theanyinstances are welcome, due to your experience with the Cartesian implementation and use cases within ElasticIssues
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts