Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Storybook created an unintentional breaking change between
5.x
and6.3
that broke@storybook/addon-storysource
when exporting stories from a central file, a non-typical approach. Upgrading storybook in #1231 broke the source tab that many consumers of@elastic/charts
rely on. This pr fixes the story source (somewhat -- only shows exported value and not full file as before) and adds back the missing@storybook/addon-actions
.Changes
Related to source fix:
storybook/stories/**/*.tsx
are renamed with the.story.tsx
extension.Unrelated to source fix:
6.3.7
. An issue with globals was limiting this but it now fixed.@storybook/addon-actions
addon inmain.js
selectedPanel
overrides in favor of global. Set to source indevelopment
and knobs otherwise.Demo of working source
Screen.Recording.2021-08-31.at.02.13.15.PM.mp4