Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: log scale improvements and options (#1014) #1030

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

nickofthyme
Copy link
Collaborator

Reverts #1014

To be discussed further.

@nickofthyme nickofthyme requested a review from markov00 February 17, 2021 14:44
@nickofthyme nickofthyme changed the title Revert "feat(axis): log scale improvements and options" fix: revert "feat(axis): log scale improvements and options (#1014)" Feb 17, 2021
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM

@nickofthyme nickofthyme changed the title fix: revert "feat(axis): log scale improvements and options (#1014)" revert: log scale improvements and options (#1014) Feb 17, 2021
@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #1030 (a5e1ec1) into master (0f52688) will increase coverage by 0.32%.
The diff coverage is 84.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
+ Coverage   72.86%   73.18%   +0.32%     
==========================================
  Files         363      379      +16     
  Lines       11235    11518     +283     
  Branches     2446     2482      +36     
==========================================
+ Hits         8186     8430     +244     
- Misses       3035     3066      +31     
- Partials       14       22       +8     
Flag Coverage Δ
unittests 72.78% <84.48%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../chart_types/heatmap/layout/viewmodel/viewmodel.ts 4.37% <0.00%> (ø)
src/chart_types/index.ts 100.00% <ø> (ø)
...y_chart/state/selectors/compute_axes_geometries.ts 100.00% <ø> (ø)
...t/state/selectors/compute_axis_ticks_dimensions.ts 100.00% <ø> (ø)
...chart/state/selectors/compute_series_geometries.ts 100.00% <ø> (ø)
src/chart_types/xy_chart/state/utils/utils.ts 96.60% <ø> (-0.02%) ⬇️
src/chart_types/xy_chart/utils/specs.ts 100.00% <ø> (ø)
src/scales/constants.ts 100.00% <ø> (ø)
src/scales/index.ts 100.00% <ø> (ø)
src/scales/scale_band.ts 92.85% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c3ac9...a5e1ec1. Read the comment docs.

@nickofthyme nickofthyme merged commit 2189f92 into master Feb 17, 2021
@nickofthyme nickofthyme deleted the revert-1014-log-options branch February 17, 2021 15:15
@markov00
Copy link
Member

🎉 This PR is included in version 25.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants