Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xy): default min domain for log scales to baseline value #1028

Closed

Conversation

markov00
Copy link
Member

Summary

The #1014 PR introduced a breaking change that causes the log scale to use always the min value of the data domain as the min value for the scale domain.
This creates a, probably unwanted, breaking change because suddenly every Y axis using a log scale will be scaled to from the min to the max value of the datum, as opposed to the actual implementation that always scales from a minimum value of 1 (the LOG base min) to the max of the domain.

@markov00 markov00 added bug Something isn't working :data Data/series/scales related issue labels Feb 17, 2021
@markov00 markov00 requested a review from nickofthyme February 17, 2021 11:43
@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #1028 (313bd83) into master (0f52688) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
+ Coverage   72.86%   73.26%   +0.40%     
==========================================
  Files         363      379      +16     
  Lines       11235    11542     +307     
  Branches     2446     2494      +48     
==========================================
+ Hits         8186     8456     +270     
- Misses       3035     3064      +29     
- Partials       14       22       +8     
Flag Coverage Δ
unittests 72.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chart_types/xy_chart/domains/x_domain.ts 100.00% <100.00%> (ø)
src/chart_types/xy_chart/domains/y_domain.ts 97.93% <100.00%> (ø)
src/utils/domain.ts 97.43% <100.00%> (ø)
src/mocks/series/series.ts 91.22% <0.00%> (ø)
src/mocks/specs/index.ts 100.00% <0.00%> (ø)
src/mocks/series/data.ts 100.00% <0.00%> (ø)
src/mocks/theme.ts 86.66% <0.00%> (ø)
src/mocks/utils.ts 100.00% <0.00%> (ø)
src/mocks/scale/scale.ts 77.77% <0.00%> (ø)
src/mocks/specs/specs.ts 81.81% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c3ac9...313bd83. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :data Data/series/scales related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants