-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(annotation): enable marker positioning on LineAnnotation #737
Merged
markov00
merged 5 commits into
elastic:master
from
markov00:2020_06_30-configure_annotation_marker_position
Jul 6, 2020
Merged
feat(annotation): enable marker positioning on LineAnnotation #737
markov00
merged 5 commits into
elastic:master
from
markov00:2020_06_30-configure_annotation_marker_position
Jul 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows changing the marker position on a line annotation. The position is absolute on the screen space and doesn't depend on the chart rotation fix elastic#701
markov00
added
enhancement
New feature or request
:annotation
Annotation (line, rect, text) related issue
:xy
Bar/Line/Area chart related
labels
Jul 3, 2020
The line is now drawn starting from the opposite point and the dash follows that
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 74.80% 74.25% -0.55%
==========================================
Files 265 282 +17
Lines 8541 8883 +342
Branches 1714 1788 +74
==========================================
+ Hits 6389 6596 +207
- Misses 2099 2227 +128
- Partials 53 60 +7
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Jul 6, 2020
# [19.8.0](v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([#739](#739)) ([35b8caf](35b8caf)), closes [#723](#723) [#738](#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([#737](#737)) ([ab5e413](ab5e413)), closes [#701](#701) * add custom annotation tooltip ([#727](#727)) ([435c67c](435c67c))
🎉 This PR is included in version 19.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.8.0](elastic/elastic-charts@v19.7.0...v19.8.0) (2020-07-06) ### Bug Fixes * set uninitialized state when removeSpec action is called ([opensearch-project#739](elastic/elastic-charts#739)) ([9c49c90](elastic/elastic-charts@9c49c90)), closes [opensearch-project#723](elastic/elastic-charts#723) [opensearch-project#738](elastic/elastic-charts#738) ### Features * **annotation:** enable marker positioning on LineAnnotation ([opensearch-project#737](elastic/elastic-charts#737)) ([2fa5a0b](elastic/elastic-charts@2fa5a0b)), closes [opensearch-project#701](elastic/elastic-charts#701) * add custom annotation tooltip ([opensearch-project#727](elastic/elastic-charts#727)) ([f03d566](elastic/elastic-charts@f03d566))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:annotation
Annotation (line, rect, text) related issue
enhancement
New feature or request
released
Issue released publicly
:xy
Bar/Line/Area chart related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows changing the marker position on a line annotation. The position is absolute on
the screen space and doesn't depend on the chart rotation.
This PR adds a new optional props to the
<LineAnnotation>
component calledmarkerPosition?: Position;
The default position, if this property is not specified, falls back to the linked axis position (if available).
fix #701
Note: this PR doesn't change the fact that the size of the marker doesn't participate in the automatic calculation of the padding around the chart: this means that if the marker is bigger than the available padding the marker will overflow the chart component.
Checklist
Delete any items that are not applicable to this PR.