-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y-axis brushing #587
Closed
2 of 3 tasks
Labels
enhancement
New feature or request
:interactions
Interactions related issue
released
Issue released publicly
Comments
markov00
added a commit
to markov00/elastic-charts
that referenced
this issue
Apr 10, 2020
This commit allow the consumer to configure the direction used for the brush tool. The direction is by default along the X axis, but can be changed to be along the Y axis or have a rectangular selection along both axis. For the Y axis values, we are returning an array of values, one for each Y axis defined (this is determined by the groupId associated with different axis/series groups) BREAKING CHANGE: The type used by the `BrushEndListener` is now changed to reflect this change. The new type is on form of `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number, number]; }> }` where x contains an array of [min,max] values, and the y property is an optional array of objects, containing the GroupId and the values of the brush for that specific axis. fix elastic#587
markov00
added a commit
that referenced
this issue
Apr 28, 2020
This commit allows the consumer to configure the direction used for the brush tool. The direction is, by default, along the X-axis, but can be changed to be along the Y-axis or have a rectangular selection along both axes. For each Y-axis defined (usually determined by an associated `groupId`) we return a scaled set of `[min, max]` values. BREAKING CHANGE: The type used by the `BrushEndListener` is now in the following form `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number, number]; }> }` where `x` contains an array of `[min, max]` values, and the `y` property is an optional array of objects, containing the `GroupId` and the values of the brush for that specific axis. fix #587, fix #620
markov00
pushed a commit
that referenced
this issue
Apr 28, 2020
# [19.0.0](v18.4.2...v19.0.0) (2020-04-28) ### Bug Fixes * tooltip container scroll issue ([#647](#647)) ([f411771](f411771)) * **annotations:** fix alignment at the edges ([#641](#641)) ([43c5a59](43c5a59)), closes [#586](#586) ### Features * shift click legend items & partition legend hover ([#648](#648)) ([ed91744](ed91744)) * **brush:** add multi axis brushing ([#625](#625)) ([9e49534](9e49534)), closes [#587](#587) [#620](#620) ### BREAKING CHANGES * **brush:** The type used by the `BrushEndListener` is now in the following form `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number, number]; }> }` where `x` contains an array of `[min, max]` values, and the `y` property is an optional array of objects, containing the `GroupId` and the values of the brush for that specific axis. * **annotations:** In the rectangular annotation, the y0 parameter of the coordinates now refers to the minimum value and the y1 value refers to the maximum value of the y domain.
🎉 This issue has been resolved in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this issue
Feb 10, 2022
# [19.0.0](elastic/elastic-charts@v18.4.2...v19.0.0) (2020-04-28) ### Bug Fixes * tooltip container scroll issue ([opensearch-project#647](elastic/elastic-charts#647)) ([f0af34b](elastic/elastic-charts@f0af34b)) * **annotations:** fix alignment at the edges ([opensearch-project#641](elastic/elastic-charts#641)) ([c698d08](elastic/elastic-charts@c698d08)), closes [opensearch-project#586](elastic/elastic-charts#586) ### Features * shift click legend items & partition legend hover ([opensearch-project#648](elastic/elastic-charts#648)) ([cf15ca1](elastic/elastic-charts@cf15ca1)) * **brush:** add multi axis brushing ([opensearch-project#625](elastic/elastic-charts#625)) ([382cb14](elastic/elastic-charts@382cb14)), closes [opensearch-project#587](elastic/elastic-charts#587) [opensearch-project#620](elastic/elastic-charts#620) ### BREAKING CHANGES * **brush:** The type used by the `BrushEndListener` is now in the following form `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number, number]; }> }` where `x` contains an array of `[min, max]` values, and the `y` property is an optional array of objects, containing the `GroupId` and the values of the brush for that specific axis. * **annotations:** In the rectangular annotation, the y0 parameter of the coordinates now refers to the minimum value and the y1 value refers to the maximum value of the y domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
:interactions
Interactions related issue
released
Issue released publicly
Is your feature request related to a problem? Please describe.
When using
onBrushEnd
with a chart, brushing only happens along the x-axis.Describe the solution you'd like
I'd like to allow brushing along the y-axis instead of the x-axis. (Perhaps also both, with a rectangular selection, but this is not needed for my use case.)
Kibana Cross Issues
Work using this is happening in elastic/kibana#59496.
Checklist
Kibana Cross Issues
listkibana cross issue
tag is associated to the issue if any kibana cross issue is presentThe text was updated successfully, but these errors were encountered: