Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Charts] Annotations should have click handler #1211

Closed
3 tasks
alvarezmelissa87 opened this issue Jun 21, 2021 · 3 comments · Fixed by #1293 or elastic/kibana#113968
Closed
3 tasks

[Charts] Annotations should have click handler #1211

alvarezmelissa87 opened this issue Jun 21, 2021 · 3 comments · Fixed by #1293 or elastic/kibana#113968
Assignees
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :interactions Interactions related issue released Issue released publicly

Comments

@alvarezmelissa87
Copy link

alvarezmelissa87 commented Jun 21, 2021

Is your feature request related to a problem? Please describe.
When using the chart annotations, I am unable to hook into interactions with the annotation.

Describe the solution you'd like
I would like to have an event handler (preferably click) that I can pass in so that I can easily trigger some other action from a click on the annotation. The handler I pass in would probably expect the annotation data as a parameter.

Describe alternatives you've considered
No alternatives I could find for the use case I'd like.

Kibana Cross Issues
Add any Kibana related issues/feature requests here.

Target Release
Would be great to get this in soon, if possible. 7.14 would be great but mindful it's a bit of a squeeze so 7.15 would be great, also. Thank you!

Checklist

Delete any items that are not applicable to this feature request.

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@alvarezmelissa87 alvarezmelissa87 added the enhancement New feature or request label Jun 21, 2021
@nickofthyme nickofthyme added :annotation Annotation (line, rect, text) related issue :interactions Interactions related issue labels Jun 21, 2021
@rshen91 rshen91 self-assigned this Aug 9, 2021
@rshen91
Copy link
Contributor

rshen91 commented Aug 16, 2021

@alvarezmelissa87 What kind of annotation data would you like to have access to from within handler (if any)? Thanks!

@alvarezmelissa87
Copy link
Author

Hi @rshen91 - so for LineAnnotation it should be dataValue and details and for RectAnnotation everything - coordinates and details. Thank you and please let me know if there's anything else I can help with!

nickofthyme pushed a commit that referenced this issue Sep 13, 2021
# [35.0.0](v34.2.1...v35.0.0) (2021-09-13)

### Bug Fixes

* **a11y:** restore focus after popover close with color picker ([#1272](#1272)) ([0c6f945](0c6f945)), closes [#1266](#1266) [#935](#935)
* **build:** fix license in package.json ([#1362](#1362)) ([d524fdf](d524fdf))
* **deps:** update dependency @elastic/eui to ^37.5.0 ([#1341](#1341)) ([fb05c98](fb05c98))
* **deps:** update dependency @elastic/eui to ^37.6.1 ([#1359](#1359)) ([2ae90ce](2ae90ce))
* **deps:** update dependency @elastic/eui to ^37.7.0 ([#1373](#1373)) ([553b6b0](553b6b0))
* **heatmap:** filter out tooltip picked shapes in x-axis area ([#1351](#1351)) ([174047d](174047d)), closes [#1215](#1215)
* **heatmap:** remove values when brushing only over axes ([#1364](#1364)) ([77ff8d3](77ff8d3))

### Features

* **annotations:** add onClickHandler for annotations ([#1293](#1293)) ([48198be](48198be)), closes [#1211](#1211)
* **heatmap:** add text color contrast to heatmap cells ([#1342](#1342)) ([f9a26ef](f9a26ef)), closes [#1296](#1296)
* **heatmap:** reduce font size to fit label within cells ([#1352](#1352)) ([16b5546](16b5546))
* **xy:** mutilayer time axis step 1 ([#1326](#1326)) ([867b1f5](867b1f5))

### BREAKING CHANGES

* **xy:** - feat: removes the axis deduplication feature
- fix: `showDuplicatedTicks` causes a duplication check on the actual axis tick label (possibly yielded by `Axis.tickLabel` rather than the more general `tickFormat`)
* **heatmap:** the `config.label.fontSize` prop is replaced by `config.label.minFontSize` and `config.label.maxFontSize`. You can specify the same value for both properties to have a fixed font size. The `config.label.align` and `config.label.baseline` props are removed from the `HeatmapConfig` object.
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 35.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :interactions Interactions related issue released Issue released publicly
Projects
None yet
3 participants