refactor: decouple directly chart dependent logic from the interactio…

…n reducer
elastic · Feb 6, 2021 · 7e32a70 · 7e32a70
1 parent 7137cd0
commit 7e32a70
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/src/state/reducers/interactions.ts b/src/state/reducers/interactions.ts
@@ -17,6 +17,7 @@
  * under the License.
  */
 
+import { ChartTypes } from '../../chart_types';
 import { getPickedShapesLayerValues } from '../../chart_types/partition_chart/state/selectors/picked_shapes';
 import { getSeriesIndex } from '../../chart_types/xy_chart/utils/series';
 import { LegendItem } from '../../common/legend';
@@ -82,10 +83,9 @@ export function interactionsReducer(
         },
       };
     case ON_MOUSE_DOWN:
-      const layerValues: LayerValue[] = getPickedShapesLayerValues(globalState)[0];
       return {
         ...state,
-        drilldown: layerValues ? layerValues[layerValues.length - 1].path.map((n) => n.value) : [],
+        drilldown: getDrilldownData(globalState),
         pointer: {
           ...state.pointer,
           dragging: false,
@@ -174,7 +174,10 @@ export function interactionsReducer(
   }
 }
 
-/** @internal */
+/**
+ * Helper functions that currently depend on chart type eg. xy or partition
+ */
+
 function toggleDeselectedDataSeries(
   { legendItemId: id, negate }: ToggleDeselectSeriesAction,
   deselectedDataSeries: SeriesIdentifier[],
@@ -199,3 +202,11 @@ function toggleDeselectedDataSeries(
   }
   return [...deselectedDataSeries, id];
 }
+
+function getDrilldownData(globalState: GlobalChartState) {
+  if (globalState.chartType !== ChartTypes.Partition) {
+    return [];
+  }
+  const layerValues: LayerValue[] = getPickedShapesLayerValues(globalState)[0];
+  return layerValues ? layerValues[layerValues.length - 1].path.map((n) => n.value) : [];
+}