[k8s] fix hints stream missing ids #6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
bug
…n container logs is enabled
pkoutsovasilis
force-pushed
the
k8s/fix_hints_stream_ids
branch
from
aa09b42 to
8265572
Compare
|
buildkite test extended |
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Looks like we need to add the ID here. I'll take care of it. |
swiatekm
approved these changes
Jan 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
* fix: add required ids in hints input streams of type filestream * feat: disable hints default_container_logs when kubernetes integration container logs is enabled (cherry picked from commit 7ad0456)
4 tasks
pkoutsovasilis
added a commit
that referenced
this pull request
Jan 9, 2025
* fix: add required ids in hints input streams of type filestream * feat: disable hints default_container_logs when kubernetes integration container logs is enabled (cherry picked from commit 7ad0456) Co-authored-by: Panos Koutsovasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After this PR got merged our k8s CI test started failing. After investigating I realised that all the hint-based inputs are lacking streams IDs in the respective filestream inputs resulting in all of them registering with an empty ID and thus colliding. Also, during this investigation, I realised that by default when hints are enabled are capturing the logs of containers that do not feature a hints-related annotation. Thus I updated the Helm chart to explicitly disable the former when both the contailer logs of kubernetes integration and hints are enabled.
A fix should also happen in the actual job that fabricates and introduces these templates
Why is it important?
Because it fixes an actual bug and it brings the CI back to green
Checklist
Disruptive User Impact
None
How to test this PR locally
Related issues
N/A