Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #6109) Make redaction of common keys in diagnostics case insensitive #6198

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2024

What does this PR do?

Changes the redaction of common keys like "password" to be case insensitive. This means keys like "PASSWORD" and "PassWord" will also be redacted.

Why is it important?

To prevent leaking secrets into diagnostics.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
    • I couldn't find any docs on diagnostics redaction
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

This may cause keys that were previously not redacted to be redacted after the change. For example, the "Key" substring may be common in configuration keys that don't need redaction.

How to test this PR locally

cd internal/pkg/diagnostics
go test .
```<hr>This is an automatic backport of pull request #6109 done by [Mergify](https://mergify.com).

* Make common key redaction case insensitive

* add changelog entry

* change to bug fix

---------

Co-authored-by: Shaunak Kashyap <[email protected]>
(cherry picked from commit 8939f0f)
@mergify mergify bot requested a review from a team as a code owner December 3, 2024 16:48
@mergify mergify bot added the backport label Dec 3, 2024
@mergify mergify bot requested review from kaanyalti and andrzej-stencel and removed request for a team December 3, 2024 16:48
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@andrzej-stencel andrzej-stencel merged commit 026366d into 8.17 Dec 4, 2024
14 of 15 checks passed
@andrzej-stencel andrzej-stencel deleted the mergify/bp/8.17/pr-6109 branch December 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant