Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #6065) Skip notifyFleetAuditUninstall on Windows #6072

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 18, 2024

What does this PR do?

Skips calling notifyFleetAuditUninstall on Windows.

When enabled it makes it much more likely that a panic will occur, but this doesn't actually seem like the culprit it just makes it more likely to happen.

NOTE: This doesn't actually fix the issue on Windows, it just makes it less likely to occur. Even with this disabled I am still seeing uninstall failing on like the 68th retry, but with this enabled it more likely happens on the 6-8th try. This is just reducing the likely that this issue occurs, it is not actually fixing the issue. (Just want to make that clear).

Why is it important?

Reduces changes that uninstall happens on Windows.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues


This is an automatic backport of pull request #6065 done by [Mergify](https://mergify.com).

* Skip notifyFleetAuditUninstall on Windows.

(cherry picked from commit 4e98344)
@mergify mergify bot requested a review from a team as a code owner November 18, 2024 23:41
@mergify mergify bot added the backport label Nov 18, 2024
@mergify mergify bot requested review from blakerouse and andrzej-stencel and removed request for a team November 18, 2024 23:41
@cmacknz cmacknz enabled auto-merge (squash) November 19, 2024 00:08
@cmacknz cmacknz merged commit b6da7f8 into 8.16 Nov 19, 2024
15 checks passed
@cmacknz cmacknz deleted the mergify/bp/8.16/pr-6065 branch November 19, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants