[8.x](backport #5879) Assume installed agent on upgrade #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit ab2b7ee)
mergify
bot
requested review from
pkoutsovasilis and
michel-laterman
and removed request for
a team
pierrehilbert
requested review from
michalpristas
and removed request for
pkoutsovasilis and
michel-laterman
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pierrehilbert
approved these changes
Nov 4, 2024
|
|
Failure should be resolved by #5902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR assumes installed agent on upgrade.
Detecting installed based on marker file does not work prior to 8.8 as marker file is not there leading to incorrect control path.
During upgrade we resolve paths to proper value assuming upgrading agent is installed (as this is requirement anyways).
Other way would be to keep
runningInstalledevaluation based on paths as before OR have two ways of detecting installed agent during upgrade based on previous agent version.Why is it important?
To make ugprade from <8.8 work
Fixes #5872
This is an automatic backport of pull request #5879 done by Mergify.