[Flaky Test] Fix TestHTTPSProxy #5878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
From what I understood, it should close the flaky test issue right? |
My bad, I fixed it |
andrzej-stencel
approved these changes
Oct 30, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 02fb75e) # Conflicts: # testing/proxytest/proxytest_test.go
1 task
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 02fb75e) # Conflicts: # testing/proxytest/proxytest_test.go
1 task
AndersonQ
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 02fb75e) # Conflicts: # testing/proxytest/proxytest_test.go
AndersonQ
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 02fb75e) # Conflicts: # testing/proxytest/proxytest_test.go
AndersonQ
added a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 02fb75e)
AndersonQ
added a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 02fb75e)
AndersonQ
added a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 02fb75e)
AndersonQ
added a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 02fb75e)
AndersonQ
added a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit 02fb75e) Co-authored-by: Anderson Queiroz <[email protected]>
AndersonQ
added a commit
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 02fb75e) --------- Co-authored-by: Anderson Queiroz <[email protected]>
AndersonQ
added a commit
that referenced
this pull request
Dec 2, 2024
… closing the server (#5970) * (backport #5878) proxytest: fix log after test finished (#5878) (cherry picked from commit 02fb75e) --------- Co-authored-by: Anderson Queiroz <[email protected]> * (backport #5950) [proxytest] Await requests before server shutdown #5970 (cherry picked from commit e423d73) --------- Co-authored-by: Anderson Queiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It moves the close of the proxy and target http server to
t.Cleanup()Why is it important?
Just using
deferwas causing the last request log to be logged after the test had ended, what lead to a panic.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
On a Mac (the panics happened on Mac)
It should succeed
Related issues
Questions to ask yourself