test: use a lower unenroll timeout in TestActionUnenrollHandler #5465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
auto unenroll with no running components is timing out after 15s due to hardcoded unenrollTimeout.
There is no need to use a huge timeout in test. Pass the timeout as a method arg and use a lower timeout.
Test time went from 15s to 0.1s
Why is it important?
slow tests are not good
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
go test ./internal/pkg/agent/application/actions/handlers/. -run=TestActionUnenrollHandler/auto_unenroll_with_no_running_components -v
Related issues
Questions to ask yourself