Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/elastic/elastic-agent-autodiscover from 0.6.8 to 0.6.11 #4510

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2024

Bumps github.com/elastic/elastic-agent-autodiscover from 0.6.8 to 0.6.11.

Release notes

Sourced from github.com/elastic/elastic-agent-autodiscover's releases.

v0.6.11

What's Changed

Full Changelog: elastic/elastic-agent-autodiscover@v0.6.10...v0.6.11

v0.6.10

What's Changed

Full Changelog: elastic/elastic-agent-autodiscover@v0.6.9...v0.6.10

v0.6.9

What's Changed

New Contributors

Full Changelog: elastic/elastic-agent-autodiscover@v0.6.8...v0.6.9

v.0.6.9

What's Changed

New Contributors

Full Changelog: elastic/elastic-agent-autodiscover@v0.6.8...v.0.6.9

Commits
  • cd0e892 Bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible...
  • 64452f4 Bump google.golang.org/protobuf from 1.29.1 to 1.33.0 (#84)
  • 7490558 Introduce checks for not supported annotations for Hints based autodiscover o...
  • b3b1fa7 security: add permissions block to workflows (#80)
  • 4554e51 [updatecli] Bump Golang version to 1.21.8 (#82)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/elastic/elastic-agent-autodiscover](https://github.com/elastic/elastic-agent-autodiscover) from 0.6.8 to 0.6.11.
- [Release notes](https://github.com/elastic/elastic-agent-autodiscover/releases)
- [Changelog](https://github.com/elastic/elastic-agent-autodiscover/blob/main/CHANGELOG.md)
- [Commits](elastic/elastic-agent-autodiscover@v0.6.8...v0.6.11)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-autodiscover
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner April 3, 2024 21:09
@dependabot dependabot bot requested review from AndersonQ and pchila April 3, 2024 21:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

mergify bot commented Apr 3, 2024

This pull request does not have a backport label. Could you fix it @dependabot[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Apr 3, 2024
@rdner
Copy link
Member

rdner commented Apr 5, 2024

There are some syntax errors, looks like a breaking change was introduced:

# github.com/elastic/elastic-agent/internal/pkg/composable/providers/kubernetes
internal/pkg/composable/providers/kubernetes/hints.go:291:20: assignment mismatch: 1 variable but utils.GenerateHints returns 2 values
internal/pkg/composable/providers/kubernetes/hints.go:291:60: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)
internal/pkg/composable/providers/kubernetes/pod.go:215:14: assignment mismatch: 1 variable but utils.GenerateHints returns 2 values
internal/pkg/composable/providers/kubernetes/pod.go:215:51: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)
# github.com/elastic/elastic-agent/internal/pkg/composable/providers/kubernetes
vet: internal/pkg/composable/providers/kubernetes/hints.go:291:66: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)

@AndersonQ
Copy link
Member

There are some syntax errors, looks like a breaking change was introduced:

# github.com/elastic/elastic-agent/internal/pkg/composable/providers/kubernetes
internal/pkg/composable/providers/kubernetes/hints.go:291:20: assignment mismatch: 1 variable but utils.GenerateHints returns 2 values
internal/pkg/composable/providers/kubernetes/hints.go:291:60: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)
internal/pkg/composable/providers/kubernetes/pod.go:215:14: assignment mismatch: 1 variable but utils.GenerateHints returns 2 values
internal/pkg/composable/providers/kubernetes/pod.go:215:51: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)
# github.com/elastic/elastic-agent/internal/pkg/composable/providers/kubernetes
vet: internal/pkg/composable/providers/kubernetes/hints.go:291:66: not enough arguments in call to utils.GenerateHints
	have (mapstr.M, string, string)
	want (mapstr.M, string, string, []string)

FYI: @pierrehilbert, @cmacknz

this seems to be the culprit:
https://github.com/elastic/elastic-agent-autodiscover/pull/81/files#diff-99d5db949c88160c717cd1240bed90ec4da0d96b04cd287de3ca53d0cd90e4bfR205

however, I haven't worked with the autodiscover, I'm not sure where to find the allSupportedHints for the agent. It's the new parameter which was added on v0.6.9.

@cmacknz
Copy link
Member

cmacknz commented Apr 8, 2024

@cmacknz cmacknz closed this Apr 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 8, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@cmacknz cmacknz deleted the dependabot/go_modules/github.com/elastic/elastic-agent-autodiscover-0.6.11 branch April 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants