add integration test for install via RPM on SLES #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @leehinman? 🙏
NOTE: |
leehinman
force-pushed
the
4086_add_sles15
branch
from
8f61642 to
3e87ee3
Compare
|
0.0% Duplication on New Code
leehinman
changed the title
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
rdner
approved these changes
Mar 22, 2024
| @@ -125,7 +125,75 @@ func TestDebLogIngestFleetManaged(t *testing.T) { | |||
| // name. This policy does not contain any integration. | |||
| t.Log("Enrolling agent in Fleet with a test policy") | |||
| createPolicyReq := kibana.AgentPolicy{ | |||
| Name: fmt.Sprintf("test-policy-enroll-%d", time.Now().Unix()), | |||
| Name: fmt.Sprintf("test-policy-enroll-%s", uuid.New().String()), | |||
There was a problem hiding this comment.
Thank you!
Related to #4421
I guess this test was not there when I fixed it 🙂
pchila
approved these changes
Mar 22, 2024
rdner
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Integration test that uses SLES 15 AMD to test fleet managed elastic-agent installed via RPM.
Only AMD was added because at the moment ogc doesn't support SLES ARM on GCP. Also looked at implementing #4301 (comment) This was skipped because adding a slice of strings (for supported package formats) to the OS struct broke comparison of OS structs. I think this is still worth doing, just in a separate PR because it is likely to change a fair number of things.
Why is it important?
Need to test our RPM builds
Checklist
./changelog/fragmentsusing the changelog toolAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself