Give TestCloseChannel more time to close the channel #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initial wait is short it's possible that `time.After` unblocks faster than the channel gets closed. Which makes this test to fail.
rdner
added
Team:Elastic-Agent
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
0.0% Duplication on New Code
cmacknz
approved these changes
Mar 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
If the initial wait is short it's possible that `time.After` unblocks faster than the channel gets closed. Which makes this test to fail. (cherry picked from commit 775e020)
rdner
added a commit
that referenced
this pull request
Mar 18, 2024
If the initial wait is short it's possible that `time.After` unblocks faster than the channel gets closed. Which makes this test to fail. (cherry picked from commit 775e020) Co-authored-by: Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial wait is short it's possible that
time.Afterunblocks faster than the channel gets closed. Which makes this test to fail.Related issues