-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent]-PR- Introduce log message for not supported annotations for Hints based autodiscover #4360
Merged
[Elastic Agent]-PR- Introduce log message for not supported annotations for Hints based autodiscover #4360
Changes from 38 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
c60baaa
first commit with checks for hints vocabulary
gizas 2148751
updating code to postition in correct place and to be triggered only …
gizas 664ebea
fixing to retrieve only keys keys
gizas f44c16f
updating comment
gizas 56d5015
adding changelog fragment
gizas ffa6e15
fixing linting issues
gizas b0fd369
moved checks in elastic-agent-autodicover
gizas ea314f9
correcting namespace and adding comment
gizas 5da1316
Merge branch 'main' into logshints
gizas 6536f3a
adding checks also to containers
gizas 2aea421
udpating comment
gizas bae96be
fixing forloop error with value
gizas 531b0b7
updating print message
gizas aa14e07
updating go.mod with v0.6.9 autodiscovery library
gizas 6b06af5
Merge branch 'main' into logshints
gizas a1fdd05
updating Notice.txt
gizas 3d52fcc
Merge branch 'logshints' of github.com:elastic/elastic-agent into log…
gizas 6eb8655
removing module from supported list
gizas c52caec
removing module from supported list and added package
gizas 35231be
removing module from supported list and added package
gizas 651f91c
correcting changelog for v0.6.12
gizas a5af235
fixing conflicts with main
gizas 902b6c3
fixing conflicts with main
gizas 2432e89
fixing notice.txt
gizas 4cc176d
fixing test
gizas 6d7906d
fixing conflicts with main
gizas d09e8bc
removing default_container_logs from allSupportedHints list
gizas 890103c
updating to elastic-agent-autodiscovery v.0.6.13
gizas 74df714
Merge branch 'main' of github.com:elastic/elastic-agent into logshints
gizas 4f3d1be
merging with main
gizas f6fcf2e
Merge branch 'main' into logshints
gizas 85e7d49
adding test TestGenerateHints
gizas 98b7954
adding test TestGenerateHints
gizas 5a5e0f3
fixing conflicts
gizas 5310024
removing lables from test
gizas ff1ecf9
Update internal/pkg/composable/providers/kubernetes/hints.go
gizas 62d1b2d
removing container id and changed typo label
gizas 97491c3
Merge branch 'logshints' of github.com:elastic/elastic-agent into log…
gizas 258aa5f
fixing conflicts
gizas 725440b
Merge branch 'main' into logshints
gizas aca7696
fixing conflicts with main
gizas a44c62a
removing bin folder
gizas 77ea366
Merge branch 'main' of github.com:elastic/elastic-agent into logshints
gizas 4fdf8e0
Merge branch 'main' into logshints
rdner a221dee
Merge branch 'main' into logshints
gizas 88cb012
adding function to override sonarcube
gizas fe3548f
adding function to override sonarcube
gizas 2512f64
Merge branch 'main' into logshints
gizas dfb1945
Merge branch 'main' into logshints
gizas 0cb2591
Merge branch 'main' into logshints
gizas e8318ae
Merge branch 'main' into logshints
gizas c191f4b
Merge branch 'main' into logshints
cmacknz d32fe34
merging with main
gizas fd7dcfd
Merge branch 'logshints' of github.com:elastic/elastic-agent into log…
gizas e6c8118
merging with main
gizas 49af807
Merge branch 'main' into logshints
gizas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Kind can be one of: | ||
| # - breaking-change: a change to previously-documented behavior | ||
| # - deprecation: functionality that is being removed in a later release | ||
| # - bug-fix: fixes a problem in a previous version | ||
| # - enhancement: extends functionality but does not break or fix existing behavior | ||
| # - feature: new functionality | ||
| # - known-issue: problems that we are aware of in a given version | ||
| # - security: impacts on the security of a product or a user’s deployment. | ||
| # - upgrade: important information for someone upgrading from a prior version | ||
| # - other: does not fit into any of the other categories | ||
| kind: enhancement | ||
|
|
||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Introduce log message for not supported annotations for Hints based autodiscover | ||
|
|
||
| # Long description; in case the summary is not enough to describe the change | ||
| # this field accommodate a description without length limits. | ||
| # NOTE: This field will be rendered only for breaking-change and known-issue kinds at the moment. | ||
| #description: | ||
|
|
||
| # Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
| component: elastic-agent | ||
|
|
||
| # PR URL; optional; the PR number that added the changeset. | ||
| # If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
| # NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
| # Please provide it if you are adding a fragment for a different PR. | ||
| pr: https://github.com/elastic/elastic-agent/pull/4360 | ||
|
|
||
| # Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). | ||
| # If not present is automatically filled by the tooling with the issue linked to the PR number. | ||
| issue: https://github.com/elastic/elastic-agent/issues/3064 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be here. Happens sometimes when the build directory has extracted beats in it. This needs to be cleaned up before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @blakerouse, I cleaned /bin folder and made the update.
Seems that not got passed and check-ci does not fail
(The failures are not related with this changes I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakerouse I have tried to re-run the build with no luck.
I can see lots of
ResourceExistsErrorAlso for the SonarQube Analysis do you have a suggestion?