Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mage and go buildkit script exit codes #3149

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix mage and go buildkit script exit codes #3149

merged 1 commit into from
Jul 31, 2023

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Fixes the buildkit job to fail when mage or go functions actual fail.

Why is it important?

Without this change CI integration failures will not mark the tests as failed.

Related issues

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team skip-changelog backport-v8.9.0 Automated backport with mergify labels Jul 28, 2023
@blakerouse blakerouse requested a review from a team as a code owner July 28, 2023 18:14
@blakerouse blakerouse self-assigned this Jul 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

pchila
pchila approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-28T18:14:20.920+0000

  • Duration: 27 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 6153
Skipped 31
Total 6184

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 68.75% (187/272) 👍
Classes 67.659% (341/504) 👍
Methods 54.228% (1071/1975) 👍
Lines 40.457% (12281/30356) 👎 -0.049
Conditionals 100.0% (0/0) 💚

@blakerouse
Copy link
Contributor Author

The failing test shows this clearly fixes the issue. What is interesting is the failure, possible that the test was merged thinking that it worked, but really it didn't.

@blakerouse
Copy link
Contributor Author

buildkite test this

@pierrehilbert pierrehilbert requested a review from pazone July 30, 2023 13:46
@blakerouse
Copy link
Contributor Author

The failures in the integration tests from this PR is from the fact that the integration testing is actually failing. The previous changed hide that fact and I believe some changes or new tests have broken the integration tests.

This should be force merged, so we are forced to fix the CI.

@pierrehilbert pierrehilbert merged commit f2e4f71 into elastic:main Jul 31, 2023
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@blakerouse @mergify
Fix mage and go buildkit script exit codes. (#3149)
f077742 
(cherry picked from commit f2e4f71)

# Conflicts:
#	.buildkite/scripts/common.sh
@mergify mergify bot mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchila pchila pchila approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ was automatically assigned from elastic/elastic-agent-control-plane

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas was automatically assigned from elastic/elastic-agent-control-plane

@pazone pazone Awaiting requested review from pazone

Assignees

@blakerouse blakerouse

Labels
backport-v8.9.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI mage integration:test no longer reports as failed when a test does fail
4 participants
@blakerouse @elasticmachine @pchila @pierrehilbert