Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid SEGFAULT when cleaning up installation in integration tests fixture #2741

Merged
merged 1 commit into from
May 29, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented May 29, 2023

What does this PR do?

Fix a SIGSEGV when cleaning up agent installed using fixture functionality

Why is it important?

Integration tests fail during cleanup phase and pollute the test output

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in ./changelog/fragments using the changelog tool
    - [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels May 29, 2023
@pchila pchila requested a review from a team as a code owner May 29, 2023 13:20
@pchila pchila self-assigned this May 29, 2023
@mergify
Copy link
Contributor

mergify bot commented May 29, 2023

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pchila pchila requested review from michalpristas and removed request for michel-laterman May 29, 2023 13:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-29T13:20:28.468+0000

  • Duration: 21 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 5663
Skipped 19
Total 5682

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.611% (71/72) 👍
Files 68.273% (170/249) 👍
Classes 67.021% (315/470) 👍
Methods 53.678% (956/1781) 👍
Lines 39.513% (11013/27872) 👎 -0.002
Conditionals 100.0% (0/0) 💚

@pchila pchila merged commit 953fda0 into elastic:main May 29, 2023
@pchila pchila deleted the fix-segfault-in-integration-tests branch November 23, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants