Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull out env vars from daemonset and document them #2160

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

gsantoro
Copy link
Contributor

What does this PR do?

Document environment variables in .env files instead of leaving comments in daemonset. it also adds extra documentation

Why is it important?

It makes clear where to define env variables

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@gsantoro gsantoro added enhancement New feature or request Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team labels Jan 24, 2023
@gsantoro gsantoro self-assigned this Jan 24, 2023
@gsantoro gsantoro requested a review from a team as a code owner January 24, 2023 10:03
@gsantoro gsantoro requested review from gizas and constanca-m and removed request for a team January 24, 2023 10:03
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2023

This pull request does not have a backport label. Could you fix it @gsantoro? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-24T10:04:09.065+0000

  • Duration: 18 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 4833
Skipped 13
Total 4846

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍
Files 69.268% (142/205) 👍
Classes 69.231% (270/390) 👍
Methods 54.047% (828/1532) 👍
Lines 39.31% (9037/22989) 👎 -0.03
Conditionals 100.0% (0/0) 💚

@ChrsMark
Copy link
Member

Thanks for for the PR @gsantoro !

For my understanding: so based on these (and previous) changes we only need to define any ENV vars inside the .env files instead of having them in the k8s manifests, right?

Changes look good to me. Do we have an issue or dev doc page that explain what is the purpose of this wider change, what is missing and what are the steps forward? Sorry if I have missed it :).

@gsantoro
Copy link
Contributor Author

@ChrsMark a bit more context was linked at #1668

@gsantoro gsantoro merged commit 7dc5fd8 into elastic:main Jan 24, 2023
@gsantoro gsantoro deleted the feature/env_vars branch January 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants