-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull out env vars from daemonset and document them #2160
Conversation
This pull request does not have a backport label. Could you fix it @gsantoro? 🙏
NOTE: |
🌐 Coverage report
|
Thanks for for the PR @gsantoro ! For my understanding: so based on these (and previous) changes we only need to define any ENV vars inside the Changes look good to me. Do we have an issue or dev doc page that explain what is the purpose of this wider change, what is missing and what are the steps forward? Sorry if I have missed it :). |
What does this PR do?
Document environment variables in .env files instead of leaving comments in daemonset. it also adds extra documentation
Why is it important?
It makes clear where to define env variables
Checklist
./changelog/fragments
using the changelog toolAuthor's Checklist
How to test this PR locally
Related issues