Skip to content

Commit

Permalink
Upgrade Watcher: Fix notification channel for crashes (#2320)
Browse files Browse the repository at this point in the history
* Fix notification channel for crashes

* Adding CHANGELOG fragment
  • Loading branch information
ycombinator authored Feb 24, 2023
1 parent e66b98a commit 98b8fe7
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 1 deletion.
32 changes: 32 additions & 0 deletions changelog/fragments/1677255543-upgrade-watcher-fix-log.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Kind can be one of:
# - breaking-change: a change to previously-documented behavior
# - deprecation: functionality that is being removed in a later release
# - bug-fix: fixes a problem in a previous version
# - enhancement: extends functionality but does not break or fix existing behavior
# - feature: new functionality
# - known-issue: problems that we are aware of in a given version
# - security: impacts on the security of a product or a user’s deployment.
# - upgrade: important information for someone upgrading from a prior version
# - other: does not fit into any of the other categories
kind: bug-fix

# Change summary; a 80ish characters long description of the change.
summary: Fixes the log message being emitted by the Upgrade Watcher when a crash is detected by it.

# Long description; in case the summary is not enough to describe the change
# this field accommodate a description without length limits.
# NOTE: This field will be rendered only for breaking-change and known-issue kinds at the moment.
#description:

# Affected component; a word indicating the component this changeset affects.
component: agent

# PR URL; optional; the PR number that added the changeset.
# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added.
# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number.
# Please provide it if you are adding a fragment for a different PR.
pr: https://github.com/elastic/elastic-agent/pull/2320

# Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of).
# If not present is automatically filled by the tooling with the issue linked to the PR number.
#issue: https://github.com/owner/repo/1234
2 changes: 1 addition & 1 deletion internal/pkg/agent/cmd/watch.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func watch(ctx context.Context, tilGrace time.Duration, log *logger.Logger) erro
return err
}

crashChecker, err := upgrade.NewCrashChecker(ctx, errChan, log)
crashChecker, err := upgrade.NewCrashChecker(ctx, crashChan, log)
if err != nil {
return err
}
Expand Down

0 comments on commit 98b8fe7

Please sign in to comment.