Add GetOneRootEvent method to process handler #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
requested review from
AndersonQ and
faec
and removed request for
a team
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
belimawr
requested changes
May 10, 2024
belimawr
approved these changes
May 10, 2024
This was referenced May 17, 2024
fearful-symmetry
added a commit
that referenced
this pull request
May 17, 2024
## What does this PR do? This fixes a small bug introduced in #150, where we weren't setting the `ProcState` object while creating the root event. This is needed for elastic/beats#39620 ## Why is it important? The previous PR adds fields that weren't in events before, this fixes that. ## Checklist - [x] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is part of elastic/elastic-agent#4083
This adds a
GetOneRootEvent(). method toProcStatswe need this for elastic/elastic-agent#4083 , as that issue requires metricbeat's system/process metricset to monitor a specific PID, which it can't do now. This will have to be followed up with a change to beat itself to rope this in. This also cleans up a bit of code and adds some docs.Why is it important?
needed for elastic/elastic-agent#4083
Checklist
CHANGELOG.md