Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil hostfs option while setting up cgroups #131

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Check for nil hostfs option while setting up cgroups #131

merged 4 commits into from
Mar 4, 2024

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

This fixes a small bug where if opts.RootfsMountpoint isn't set when we call NewReaderOptions(), it can cause a panic.

Why is it important?

We don't want panics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@fearful-symmetry fearful-symmetry added the bug Something isn't working label Mar 4, 2024
@fearful-symmetry fearful-symmetry self-assigned this Mar 4, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner March 4, 2024 16:11
@fearful-symmetry fearful-symmetry requested review from ycombinator and belimawr and removed request for a team March 4, 2024 16:11
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Mar 4, 2024
@fearful-symmetry fearful-symmetry merged commit 7f008f4 into elastic:main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@fearful-symmetry fearful-symmetry

Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fearful-symmetry @cmacknz