-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[updatecli] Bump Golang version to 1.21.5 #125
Merged
cmacknz
merged 6 commits into
main
from
updatecli_89a5aea2ed724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331
Jan 8, 2024
Merged
[updatecli] Bump Golang version to 1.21.5 #125
cmacknz
merged 6 commits into
main
from
updatecli_89a5aea2ed724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/.golangci.yml" Made with ❤️️ by updatecli
... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/.go-version" Made with ❤️️ by updatecli
... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/go.mod" Made with ❤️️ by updatecli
cmacknz
requested review from
belimawr and
leehinman
and removed request for
a team
January 3, 2024 20:07
Needs #124 |
buildkite test it |
buildkite test it |
jlind23
approved these changes
Jan 5, 2024
So the failing test in CI only detects one running process which is the entrypoint of the Buildkite agent: [
{"cmdline":"/buildkite-agent/bin/buildkite-agent start","cpu":{"start_time":"2024-01-05T15:26:16.000Z","total":{"value":240}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":9},"io":{"cancelled_write_bytes":0,"read_bytes":0,"read_char":924822,"read_ops":964,"write_bytes":4096,"write_char":26046,"write_ops":179},"memory":{"rss":{"bytes":35799040,"pct":0.0003},"share":21340160,"size":1290752000},"num_threads":25,"state":"sleeping"}
] Running this in a container locally the test passes and I get: [
{"cmdline":"bash","cpu":{"start_time":"2024-01-05T19:57:43.000Z","total":{"value":80}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":4},"io":{"cancelled_write_bytes":0,"read_bytes":0,"read_char":65029,"read_ops":125,"write_bytes":0,"write_char":5557,"write_ops":71},"memory":{"rss":{"bytes":3375104,"pct":0.0002},"share":2830336,"size":4149248},"num_threads":1,"state":"sleeping"},
{"cmdline":"go test -v -run TestFilter ./metric/system/process/...","cpu":{"start_time":"2024-01-05T19:58:12.000Z","total":{"value":2690}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":8},"io":{"cancelled_write_bytes":11472896,"read_bytes":0,"read_char":630660478,"read_ops":98025,"write_bytes":302837760,"write_char":277247133,"write_ops":44004},"memory":{"rss":{"bytes":30167040,"pct":0.0021},"share":10530816,"size":1268420608},"num_threads":12,"state":"sleeping"}
] |
Merged
fearful-symmetry
added a commit
that referenced
this pull request
Jan 5, 2024
## What does this PR do? Fixes an issue that came to light with #125 In certain instances, `FilterTest` will fail, if the process with the most memory usage and most CPU usage are the same.
…d724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331
cmacknz
deleted the
updatecli_89a5aea2ed724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331
branch
January 8, 2024 18:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[updatecli] Bump Golang version to 1.21.5
What
Bump go release version with the latest release.
Further details
See changelog for 1.21.5
Generated automatically with manual CLI
Report
Changelog
Click to expand
Remark
This pull request was automatically created using Updatecli.
Please report any issues with this tool here