Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updatecli] Bump Golang version to 1.21.5 #125

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jan 3, 2024

[updatecli] Bump Golang version to 1.21.5

What

Bump go release version with the latest release.

Further details

See changelog for 1.21.5
Generated automatically with manual CLI

Report

Source:
	✔ [gomod] Get version in go.mod format(shell)
	✔ [latestGoVersion] Get Latest Go Release(githubrelease)
	✔ [minor] Get minor version in .go-version(shell)


Condition:
	✔ [dockerTag] Is docker image golang:1.21.5 published(dockerimage)
	✔ [goDefaultVersion-check] Check if defined golang version differs(shell)

Target:
	⚠ [update-go-version] Update .go-version(file)
	⚠ [update-golang.ci] Update .golangci.yml(file)
	⚠ [update-gomod] Update go.mod(file)

Changelog

Click to expand

no GitHub Release found for go1.21.5 on "https://github.com/golang/go"

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/.golangci.yml"

Made with ❤️️ by updatecli
... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/.go-version"

Made with ❤️️ by updatecli
... ll_c5kmq7v40000gn/T/updatecli/github/elastic/elastic-agent-system-metrics/go.mod"

Made with ❤️️ by updatecli
@cmacknz cmacknz requested a review from a team as a code owner January 3, 2024 20:07
@cmacknz cmacknz requested review from belimawr and leehinman and removed request for a team January 3, 2024 20:07
@cmacknz
Copy link
Member Author

cmacknz commented Jan 3, 2024

Needs #124

@cmacknz
Copy link
Member Author

cmacknz commented Jan 4, 2024

buildkite test it

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jan 4, 2024
@cmacknz
Copy link
Member Author

cmacknz commented Jan 5, 2024

buildkite test it

@cmacknz
Copy link
Member Author

cmacknz commented Jan 5, 2024

So the failing test in CI only detects one running process which is the entrypoint of the Buildkite agent:

[
    {"cmdline":"/buildkite-agent/bin/buildkite-agent start","cpu":{"start_time":"2024-01-05T15:26:16.000Z","total":{"value":240}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":9},"io":{"cancelled_write_bytes":0,"read_bytes":0,"read_char":924822,"read_ops":964,"write_bytes":4096,"write_char":26046,"write_ops":179},"memory":{"rss":{"bytes":35799040,"pct":0.0003},"share":21340160,"size":1290752000},"num_threads":25,"state":"sleeping"}
]

Running this in a container locally the test passes and I get:

[
    {"cmdline":"bash","cpu":{"start_time":"2024-01-05T19:57:43.000Z","total":{"value":80}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":4},"io":{"cancelled_write_bytes":0,"read_bytes":0,"read_char":65029,"read_ops":125,"write_bytes":0,"write_char":5557,"write_ops":71},"memory":{"rss":{"bytes":3375104,"pct":0.0002},"share":2830336,"size":4149248},"num_threads":1,"state":"sleeping"},
    {"cmdline":"go test -v -run TestFilter ./metric/system/process/...","cpu":{"start_time":"2024-01-05T19:58:12.000Z","total":{"value":2690}},"fd":{"limit":{"hard":1048576,"soft":1048576},"open":8},"io":{"cancelled_write_bytes":11472896,"read_bytes":0,"read_char":630660478,"read_ops":98025,"write_bytes":302837760,"write_char":277247133,"write_ops":44004},"memory":{"rss":{"bytes":30167040,"pct":0.0021},"share":10530816,"size":1268420608},"num_threads":12,"state":"sleeping"}
]

fearful-symmetry added a commit that referenced this pull request Jan 5, 2024
## What does this PR do?

Fixes an issue that came to light with
#125

In certain instances, `FilterTest` will fail, if the process with the
most memory usage and most CPU usage are the same.
…d724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331
@cmacknz cmacknz merged commit 448c36a into main Jan 8, 2024
5 checks passed
@cmacknz cmacknz deleted the updatecli_89a5aea2ed724df7f43cb772297a075121470c26674e8e5964d3e91292f1d331 branch January 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants