update bk bot settings #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-ri
requested review from
ycombinator and
rdner
and removed request for
a team
pierrehilbert
approved these changes
Dec 20, 2023
cmacknz
pushed a commit
to cmacknz/elastic-agent-system-metrics
that referenced
this pull request
Jan 3, 2024
## What does this PR do? Frees the memory that is allocated when PssCaptureSnapshot is called. ## Why is it important? memory leak ## Checklist - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] Written by hand. Need to figure out what needs to happen for "go generate" to work. Does not work from Mac. ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes elastic#123 - Relates elastic#123 - Requires elastic#123 - Superseds elastic#123 --> - ## Testing - run metricbeat 8.11.0 or 8.11.1 on Windows, notice memory consumption of metricbeat continually climbs - rebuild metricbeat using this pr - memory consumption rises in first 10min or so, but is steady after that
cmacknz
pushed a commit
to cmacknz/elastic-agent-system-metrics
that referenced
this pull request
Jan 3, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? This PR adds reads and writes metrics for cgroups V1. Currently, only the total of reads and writes is available and this metric alone is not really useful to understand what is happening inside a container. ## Why is it important? These metrics are important to understand what is happening inside a container running on Kubernetes or Docker and to attribute reads and writes on a host to running containers. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes elastic#123 - Relates elastic#123 - Requires elastic#123 - Superseds elastic#123 --> -
kaanyalti
added a commit
that referenced
this pull request
Apr 15, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? Upgrades elastic-agent-libs version ## Why is it important? The upgraded version of elastic-agent-libs has the upgraded go-sysinfo package which removes the dependency on the docker v24 package. Docker v24 is removed because it is in EOL. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 -->
kruskall
added a commit
that referenced
this pull request
Jun 19, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? We're using two different versions of the gopsutil library. Drop the old version and only use the modern module-aware dependency ## Why is it important? <!-- Mandatory Explain here the WHY, or the rationale/motivation for the changes. --> ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> -
kruskall
added a commit
that referenced
this pull request
Jun 19, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? <!-- Mandatory Explain here the changes you made on the PR. Please explain the WHAT: patterns used, algorithms implemented, design architecture, message processing, etc. --> ## Why is it important? Go 1.20 added support for wrapping multiple errors. Drop multierror library and use stdlib errors ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> -
pierrehilbert
pushed a commit
that referenced
this pull request
Jul 10, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? bump github.com/gofrs/uuid to current major version ## Why is it important? github.com/gofrs/uuid released v5 with proper versioning and module support. Bump to current supported version ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> -
VihasMakwana
added a commit
that referenced
this pull request
Jul 23, 2024
## What does this PR do? - Previously, we weren't passing errors to the caller while monitoring set of processes. - With the recent introduction of the status reporter for metricsets, it is impossible to change the status to degraded if such errors are not passed to the caller. - Fix this by passing errors to the caller. We also populate the process related information to our best-effort. ## Checklist - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added an entry in `CHANGELOG.md` <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> - Closes #164 --------- Co-authored-by: Craig MacKenzie <[email protected]>
VihasMakwana
added a commit
that referenced
this pull request
Jul 23, 2024
- Bug ## What does this PR do? A quick fix PR to move `NonFatalErr` to helpers.go instead of process.go. This makes sure that `NonFatalErr` compiles for all OS'. ## Why is it important? ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> - --------- Co-authored-by: Anderson Queiroz <[email protected]>
kruskall
added a commit
that referenced
this pull request
Aug 25, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? bump gopsutil to the current major version replace deprecated `syscall.Syscall` with `syscall.SyscallN` to fix linter issue ## Why is it important? v3 is no longer supported ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> -
kruskall
added a commit
that referenced
this pull request
Sep 3, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? rename 386/amd64 specific files to compile on windows and use build tags to check the architecture ## Why is it important? add windows/arm and windows/arm64 support ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> -
ev1yehor
added a commit
that referenced
this pull request
Nov 27, 2024
<!-- Type of change Please label this PR with one of the following labels, depending on the scope of your change: - Bug - Enhancement - Breaking change - Deprecation - Cleanup - Docs --> ## What does this PR do? Update catalog-info file with correct system property <!-- Mandatory Explain here the changes you made on the PR. Please explain the WHAT: patterns used, algorithms implemented, design architecture, message processing, etc. --> ## Why is it important? <!-- Mandatory Explain here the WHY, or the rationale/motivation for the changes. --> ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [ ] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.md` ## Author's Checklist <!-- Recommended Add a checklist of things that are required to be reviewed in order to have the PR approved --> - [ ] ## Related issues <!-- Recommended Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it. - Closes #123 - Relates #123 - Requires #123 - Superseds #123 --> - Relates: elastic/ingest-dev#3398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also need to allow github-actions bot
_from documentation:
allowed_list
Comma-separated list of users who are able to trigger this job
Value: user1,user2,user3
Default: _