This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
POC for logstash output #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still to do: - support async go-lumber client - support bulk_max_size - support windowing - support load balancing - support backoff - determine if codecs are needed Closes elastic#129
leehinman
requested review from
cmacknz and
fearful-symmetry
and removed request for
a team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
leehinman
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
faec
approved these changes
Jan 12, 2023
integration/logstash_test.go
Outdated
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| type LogstashEventStats struct { |
There was a problem hiding this comment.
nit: can we make this private?
output/logstash/client.go
Outdated
| lc.logger.Errorf("error reconnecting to logstash host: %w", err) | ||
| continue | ||
| } | ||
| // reset window size on reconnect |
There was a problem hiding this comment.
is this comment still needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds initial support for logstash output
still to do:
mage test:integrationWhy is it important?
logstash is required output for shipper
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have added an entry inCHANGELOG.mdorCHANGELOG-developer.md.Author's Checklist
How to test this PR locally
Related issues