-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
a50e004
to
3aa795f
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you. It looks like there will be some followup to make these tests runnable in CI / without manually starting containers, but considering the impending holiday I'm happy to worry about that after the other pending integration tests are merged.
version: '2.3' | ||
services: | ||
kafka: | ||
build: /Users/robbavey/code/elastic-agent-shipper/testing/environment/docker/dockerfiles/kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, missed this initially, it looks like this file needs to have the home directory stripped out or maybe just be deleted if you were just using it for testing the prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ Done
One other thing if you have time before merging: can you put this in |
Also fix reference to my personal directory in docker-compose file
I've moved the files @faec - ket me know if this structure works for you |
Looks great, thank you again! Don't worry about waiting on @fearful-symmetry for merge, they are already out for the holiday :-) |
What does this PR do?
This PR adds integration tests for the Kafka output, with the use cases, and some of the mechanics around reading events from a kafka topic ported from the beats output.
This PR also includes infrastructure to create a test docker image with Kafka, exposing ports to allow testing over plaintext and SSL.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.md
orCHANGELOG-developer.md
.How to test this PR locally
docker-compose up
in thetesting/environment/docker
foldermage integrationTest
Note that I needed to delete the
docker_kafka
container after each test run to allow the tests to continue to run.Related issues
Relates #166, #176