-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be good to see if @faec has input before merging
magefile.go
Outdated
archiveFullPath := filepath.Join(archivePath, archiveFileName) | ||
archive, err := os.Open(archiveFullPath) | ||
if err != nil { | ||
panic(errors.Wrapf(err, "failed opening archive %q", archiveFileName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. We have been trying to get away from the "github.com/pkg/errors" package and just go with the std library "errors" package. Would you mind switching?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to just block this in the linter config: https://github.com/elastic/beats/blob/d777593494788495055fc5b0259613c33fb51e9a/.golangci.yml#L91-L101
For reference pkg/errors and the stdlib errors are almost but not quite compatible. See elastic/beats#31702.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the mage package
target works locally for me, thanks!
What does this PR do?
This PR introduces a
mage package
command.Result of this mage package command is an archive consisting of
This archive is then consumed by elastic-agent and included in agent release artifact
Why is it important?
For agent to be able to work with shipper
Checklist
CHANGELOG.md
orCHANGELOG-developer.md
.