Initialize the interval trigger #259
Merged
+140
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without lastRotate initialized an interval trigger will always trigger a rotation the first time its callback is executed.
nicholasberlin
requested review from
AndersonQ and
belimawr
and removed request for
a team
|
@nicholasberlin do we have a test for this behavior? If not, we should probably add one. |
Done: 8686395 I've also verified this by hand with packetbeat. |
💚 Build Succeeded
History
|
|
@fearful-symmetry ready for review |
fearful-symmetry
approved these changes
Dec 3, 2024
6 tasks
nicholasberlin
added a commit
to elastic/beats
that referenced
this pull request
Dec 6, 2024
Fix a bug where log files are rotated on startup when interval is configured and rotateonstartup is disabled. Closes: #41894 Relates: elastic/elastic-agent-libs#259
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Dec 6, 2024
Fix a bug where log files are rotated on startup when interval is configured and rotateonstartup is disabled. Closes: #41894 Relates: elastic/elastic-agent-libs#259 (cherry picked from commit b1cc7c5)
6 tasks
nicholasberlin
added a commit
to elastic/beats
that referenced
this pull request
Dec 9, 2024
Fix a bug where log files are rotated on startup when interval is configured and rotateonstartup is disabled. Closes: #41894 Relates: elastic/elastic-agent-libs#259 (cherry picked from commit b1cc7c5)
nicholasberlin
added a commit
to elastic/beats
that referenced
this pull request
Dec 9, 2024
Fix a bug where log files are rotated on startup when interval is configured and rotateonstartup is disabled. Closes: #41894 Relates: elastic/elastic-agent-libs#259 (cherry picked from commit b1cc7c5) Co-authored-by: Nicholas Berlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Without lastRotate initialized, an interval trigger will always trigger a rotation the first time its callback is executed. To avoid the extra rotation this PR initializes
lastRotateon creation.Why is it important?
Users are having a bad time when setting
rotateonstartup: falseand an interval timer in the logging configuration. They correct expect that a new log will not be created on startup but the uninitialized interval timer would create one anyway.Checklist
I have commented my code, particularly in hard-to-understand areasRelated Issue
elastic/beats#41894