Add integration build tag #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test TestSyslogOutputCanBeClosed requires no syslog running on the host and root privileges to execute. Most Linux distros already have a syslog daemon running, causing test failures during development. These failures make it difficult to identify real issues with the tests. Given this, introduce an integration build tag and run this test only by default on CI. The integration build tag was previously used only for negative matches in certain tests, which is not meaningful. Remove the !integration annotations.
💚 Build Succeeded
cc @mauri870 |
mauri870
requested review from
khushijain21 and
VihasMakwana
and removed request for
a team
ycombinator
added
the
Team:Elastic-Agent-Data-Plane
VihasMakwana
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test TestSyslogOutputCanBeClosed requires no syslog running on the host and root privileges to execute. Most Linux distros already have a syslog daemon running, causing test failures during development. These failures make it difficult to identify real issues with the tests.
Given this, introduce an integration build tag and run this test only by default on CI.
The integration build tag was previously used only for negative matches in certain tests, which is not meaningful. Remove the !integration annotations.
Checklist