chore: replace deprecated Syscall* with SyscallN

[mauri870]

What does this PR do?

Replace deprecated syscall.Syscall* functions with syscall.SyscallN, a variadic version that can handle any number of arguments.

Why is it important?

Removes a deprecated function, has no side effects since the numbered variants are based on SyscallN.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works

[mauri870]

@VihasMakwana Added you as a reviewer because of your work with windows syscalls.

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: 1e4ad2e

Failed CI Steps

• :windows: Test Windows
• :junit: Junit annotate

History

cc @mauri870

[leehinman]

This is a generated file. Can we fix the generator?

[mauri870]

This is a generated file. Can we fix the generator?

Oh, I didn't notice this was autogenerated, thanks. I'll look into it.

[mauri870]

Aha, I knew I had seen this before. It turns out I modified mkwinsyscall in Go some time ago to use SyscallN only if the number of arguments exceeds 16. I believe it was decided this way to avoid unnecessary changes on users of this script for code generation.

https://go-review.googlesource.com/c/sys/+/518995

Closing this as not needed. Thanks.