[kibana]: Fix CreateFleetServerHosts and CreateFleetProxy for 8.x #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
requested review from
belimawr and
leehinman
and removed request for
a team
AndersonQ
force-pushed
the
kibana-better-errors
branch
from
93abbc2 to
a431274
Compare
AndersonQ
force-pushed
the
kibana-better-errors
branch
from
a431274 to
f4b1aa5
Compare
💚 Build Succeeded
History
cc @AndersonQ |
rdner
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix request schema and return error body
What does this PR do?
Fix the schema for CreateFleetServerHosts and CreateFleetProxy requests so 8.x accepts it instead of returning 400 - Bad request.
The validation on 9.0 is different since elastic/kibana#193326 was introduced.
Why is it important?
So the kibana APIs work with a 8.x stack
Checklist
Related Issues