certutil: restore previous GenerateChildCert signature #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It restores the previous GenerateChildCert to undo a breaking change and creates GenerateGenericChildCert with the new signature
AndersonQ
requested review from
belimawr,
mauri870 and
VihasMakwana
and removed request for
a team
VihasMakwana
approved these changes
Oct 9, 2024
testing/certutil/certutil.go
Outdated
|
|
||
| // GenerateGenericChildCert generates a x509 Certificate using priv and pub | ||
| // as the certificate's private and public keys and as a child of caCert. | ||
| // Use this function if oyu need fine control over keys or ips and certificate name, |
There was a problem hiding this comment.
Suggested change
| // Use this function if oyu need fine control over keys or ips and certificate name, | |
| // Use this function if you need fine control over keys or ips and certificate name, |
💚 Build Succeeded
History
cc @AndersonQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It restores the previous GenerateChildCert to undo a breaking change and creates GenerateGenericChildCert with the new signature
Why is it important?
The breaking change on
GenerateChildCertis affecting several integration tests on elastic-agentChecklist
Related issues