refactor: update unix build tags and add plan9 #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
resolve obscure compile errors when trying to compile on different goos.
Use unix build tags and add plan9.
We can't implement uid/gid logic without breaks as plan9 uses strings while the api requires int.
Use plan9.Dup to redirect stderr.
See https://man2.aiju.de/2/dup
On plan9,
Why is it important?
!windows
build tags is not true and causes misleading compile errors because it implies the file can be used in any goos other than windows while it's meant to be used forunix
_other
has the same problemChecklist
Author's Checklist
Related issues